Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct status messages in HTTP2 client #31

Closed
wants to merge 1 commit into from

Conversation

pcapriotti
Copy link
Contributor

The Enum instance of Status can be used to create values containing the usual values for the message. This replaces the hardcoded "fixme" value that was previously returned as part of the status.

The `Enum` instance of `Status` can be used to create values containing
the usual values for the message. This replaces the hardcoded "fixme"
value that was previously returned as part of the status.
@kazu-yamamoto kazu-yamamoto self-requested a review November 29, 2021 00:40
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

kazu-yamamoto added a commit that referenced this pull request Nov 29, 2021
@kazu-yamamoto
Copy link
Owner

Rebased and merged. Thank you for your contribution!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 12, 2022
3.0.3
* Return correct status messages in HTTP2 client
  (#31)[kazu-yamamoto/http2#31]
* Follow changes in Aeson 2
  (#32)[kazu-yamamoto/http2#32]
* Make sure connection preface is always sent first
  (#33)[kazu-yamamoto/http2#33]
* Avoid empty data (#34)[kazu-yamamoto/http2#34]

3.0.2
* Skip inserting entries that do not fit in the encoding table
  (#28)[kazu-yamamoto/http2#28]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants