Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the impact of priority on other connections #105

Closed
wants to merge 1 commit into from

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Nov 19, 2019

Priority is mostly within a connection, except when the server knows otherwise.

Fixes part of #87 and part of #46

Priority is mostly within a connection, except when the server knows otherwise.
Copy link
Owner

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about going like:

A server MUST NOT use the priority values for making schedule decisions across multiple connections, unless it knows that those connections originate from the same client. Due to this, priority information conveyed over a non-coalesced HTTP connection (e.g., HTTP/1.1) might go unused.

A client MAY use the priority values for making local scheduling choices for the requests it initiates.

The intent here is to provide clearer guidance for implementors by starting with subject (i.e. server or client) and then a RFC 2119 verb.

@@ -240,6 +240,18 @@ compatible for peers that are unaware of the extended meaning.
The scheme has a single encoding and set of functionality whether it's
conveyed via a HTTP header or within a frame.

## Impact on other connections
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Impact on other connections
## Impact on Other Connections

@@ -240,6 +240,18 @@ compatible for peers that are unaware of the extended meaning.
The scheme has a single encoding and set of functionality whether it's
conveyed via a HTTP header or within a frame.

## Impact on other connections

When multiple connections are open, the priority MAY have impact on the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own benefit at least, I would like to understand what exactly "multiple connections" means in this context. There is a difference to multiple HTTP connections to the same authority (something not recommended for H2 or H3) vs multiple connections to different authorities that all compose a page (but are serviced by the same physical machine) vs just the client having multiple TCP connections open .

@LPardue
Copy link
Collaborator

LPardue commented Nov 19, 2019

I agree with @kazuho and think his suggested wording would address the comment that I made.

@kazuho
Copy link
Owner

kazuho commented Nov 19, 2019

PS. re "a server MUST NOT use the priority values for making schedule decisions across multiple connections," I am starting to wonder if we need to be that strict. One example that will be prohibited by this provision is the use of a different congestion controller for a "background" request.

I think it might make sense to change this to SHOULD NOT, expand the Security Considerations to four sub-topics: general discussion on fairness (this PR), coalescing intermediaries (existing section 7.1), HTTP/1 (see #107), and use of different congestion controllers.

@ianswett
Copy link
Contributor Author

Feel free to close this once #110 lands if you'd like.

@LPardue LPardue closed this in #110 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants