Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code changes and documentation for end-to-end demo #52

Merged
merged 41 commits into from
Mar 7, 2024

Conversation

jeff-cohere
Copy link
Collaborator

This PR has everything that was needed to get the DTS prototype to successfully demonstrate a JGI Data Portal -> KBase file transfer, including the generation and transmittal of a manifest.

In particular:

  • error handling and logging were greatly improved in order to debug lots of configuration and permissions issues
  • materials for a static documentation website now live in the docs/ folder, and a GitHub Action auto-publishes docs for merged PRs
  • DTS now performs Globus re-authentication flows where needed to access files on Guest Collections, per Globus's REST API recommendations
  • a Dockerfile and deployment instructions were created that allow DTS to be deployed within Spin (and presumably other Docker/Kubernetes environments)

Closes #31

@jeff-cohere jeff-cohere added documentation Improvements or additions to documentation enhancement New feature or request Globus bug fix labels Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://kbase.github.io/dts/pr-preview/pr-52/
on branch gh-pages at 2024-03-07 19:07 UTC

@jeff-cohere jeff-cohere self-assigned this Mar 5, 2024
@jeff-cohere
Copy link
Collaborator Author

Sorry about the large PR, AJ. :-) A lot of it is documentation, though, so maybe that's positive? :-)

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 42.89773% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 56.96%. Comparing base (1e2d60d) to head (fe4d930).

Files Patch % Lines
tasks/tasks.go 38.13% 61 Missing and 12 partials ⚠️
endpoints/globus/endpoint.go 48.83% 59 Missing and 7 partials ⚠️
main.go 0.00% 25 Missing ⚠️
services/prototype.go 33.33% 17 Missing and 1 partial ⚠️
databases/jdp/jamo.go 56.75% 12 Missing and 4 partials ⚠️
databases/kbase/database.go 0.00% 2 Missing ⚠️
endpoints/local/endpoint.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   61.44%   56.96%   -4.49%     
==========================================
  Files          12       16       +4     
  Lines        2023     2384     +361     
==========================================
+ Hits         1243     1358     +115     
- Misses        604      845     +241     
- Partials      176      181       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deployment/Dockerfile Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@jeff-cohere jeff-cohere merged commit c8bd2c9 into main Mar 7, 2024
3 checks passed
@jeff-cohere jeff-cohere deleted the jeff-cohere/demo branch March 7, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix documentation Improvements or additions to documentation enhancement New feature or request Globus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an end-to-end demonstration of a file transfer
2 participants