Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW2 Cleanup #13

Merged
merged 27 commits into from
Sep 25, 2023
Merged

SW2 Cleanup #13

merged 27 commits into from
Sep 25, 2023

Conversation

bio-boris
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (739b924) 68.54% compared to head (3e64749) 77.38%.
Report is 6 commits behind head on develop.

❗ Current head 3e64749 differs from pull request most recent head 4047256. Consider uploading reports for the commit 4047256 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #13      +/-   ##
===========================================
+ Coverage    68.54%   77.38%   +8.83%     
===========================================
  Files           11        9       -2     
  Lines          302      588     +286     
===========================================
+ Hits           207      455     +248     
- Misses          95      133      +38     
Files Coverage Δ
src/clients/CachedAuthClient.py 100.00% <100.00%> (ø)
src/clients/CachedCatalogClient.py 100.00% <100.00%> (ø)
src/clients/KubernetesClients.py 100.00% <100.00%> (ø)
src/configs/settings.py 100.00% <100.00%> (+3.03%) ⬆️
src/dependencies/lifecycle.py 93.50% <93.50%> (ø)
src/models/models.py 89.61% <88.23%> (-4.51%) ⬇️
src/factory.py 0.00% <0.00%> (-92.31%) ⬇️
src/dependencies/k8_wrapper.py 80.51% <81.08%> (+47.18%) ⬆️
src/dependencies/status.py 21.73% <18.96%> (-9.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bio-boris bio-boris merged commit 90485bb into develop Sep 25, 2023
bio-boris added a commit that referenced this pull request Oct 19, 2023
* Renamed 'trivy' and implemented 'codeql'
* Updated README.md multiple times, including service account info
* Modified permissions and fixed configuration issues
* Enhanced testing
* Formatted code with 'black'
* Updated dependencies, including 'pydantic'
* Refactored code, including service info retrieval and version handling
* Updated Dockerfile and .gitignore
* Addressed various issues and improvements
* PR Consolidations:
  - Devops 1367 (#11) encompassed various updates and fixes
  - SW2 Cleanup (#13) and Service wizard cleanup (#17) included code refactoring, testing enhancements, and more

Co-authored-by: Boris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant