WIP013

.github/workflows/reusable_build-push.yml

@@ -45,7 +45,7 @@ jobs:
         run: npm run lint:strict
 
       - name: Run tests
-        run: npm test . -- --coverage
+        run: npm test . -- --coverage --verbose
 
       - name: Run multi-enviroment build
         run: ./scripts/build_deploy.sh

src/app/App.test.tsx

@@ -5,8 +5,25 @@ import App from './App';
 import { Provider } from 'react-redux';
 import { createTestStore } from './store';
 
-describe('Europa...', () => {
-  test('renders Navigator page link', () => {
+const consoleInfo = jest.spyOn(console, 'info');
+// This mockImplementation supresses console.info calls.
+// eslint-disable-next-line @typescript-eslint/no-empty-function
+consoleInfo.mockImplementation(() => {});
+
+describe('The main UI for Europa...', () => {
+  afterAll(() => {
+    consoleInfo.mockRestore();
+  });
+
+  afterEach(() => {
+    consoleInfo.mockClear();
+  });
+
+  beforeEach(() => {
+    consoleInfo.mockClear();
+  });
+
+  test('renders a Navigator page link', () => {
     render(
       <Provider store={createTestStore()}>
         <App />

src/common/api/utils/kbaseBaseQuery.ts

@@ -102,8 +102,6 @@ export const isKBaseBaseQueryError = (
 ): error is KBaseBaseQueryError => {
   const fbq = isFetchBaseQueryError(error);
   const condition = fbq && isJsonRpcError(error.data);
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  console.log({ error, data: (error as any).data, fbq, condition }); // eslint-disable-line no-console
   return condition;
 };
 

src/features/layout/LeftNavBar.tsx

@@ -37,12 +37,15 @@ const LeftNavBar: FC = () => {
   );
 };
 
+const devDomains = new Set(['', 'ci-europa.kbase.us']);
+
 const DevNav: FC = () => {
   const me = useAppSelector(authMe);
   useAuthMe();
-  console.log({ me }); // eslint-disable-line no-console
+  const devDomain = !devDomains.has(process.env.REACT_APP_KBASE_DOMAIN || '');
   const customroles = me && new Set(me.customroles);
-  const dev = customroles && customroles.has('UI_COLLECTIONS');
+  const devRole = customroles && customroles.has('UI_COLLECTIONS');
+  const dev = devDomain || devRole;
   if (!dev) return <></>;
   return (
     <>

src/features/navigator/NarrativeControl/Delete.test.tsx

@@ -11,11 +11,6 @@ import { noOp } from '../../common';
 import { testNarrativeDoc, testNarrativeDocFactory } from '../fixtures';
 import { DeleteTemplate } from './NarrativeControl.stories';
 
-const consoleError = jest.spyOn(console, 'error');
-// This mockImplementation supresses console.error calls.
-// eslint-disable-next-line @typescript-eslint/no-empty-function
-// consoleError.mockImplementation(() => {});
-
 const wsIdError = 1111111;
 
 export const testNarrativeDocError = testNarrativeDocFactory({
@@ -49,6 +44,11 @@ const TestingError: FC<FallbackProps> = ({ error }) => {
   return <>Error: {JSON.stringify(error)}</>;
 };
 
+const consoleError = jest.spyOn(console, 'error');
+// This mockImplementation supresses console.error calls.
+// eslint-disable-next-line @typescript-eslint/no-empty-function
+consoleError.mockImplementation(() => {});
+
 const logError = (error: Error, info: { componentStack: string }) => {
   console.log({ error }); // eslint-disable-line no-console
   console.log(info.componentStack); // eslint-disable-line no-console
@@ -61,17 +61,17 @@ describe('The <Delete /> component...', () => {
   });
 
   afterAll(() => {
-    // consoleError.mockRestore();
+    consoleError.mockRestore();
     disableFetchMocks();
   });
 
   afterEach(() => {
-    // consoleError.mockClear();
+    consoleError.mockClear();
   });
 
   beforeEach(() => {
     fetchMock.resetMocks();
-    // consoleError.mockClear();
+    consoleError.mockClear();
   });
 
   test('renders.', () => {

src/features/navigator/NarrativeControl/Delete.tsx

@@ -32,10 +32,8 @@ export const Delete: FC<ControlProps> = ({ narrativeDoc, modalClose }) => {
     setUserConfirmation(true);
     modalClose();
     dispatch(deleteNarrative({ wsId }));
-    console.log({ userConfirmation, wsId }); // eslint-disable-line no-console
     try {
-      const out = await deleteTrigger({ wsId }).unwrap();
-      console.log({ out }); // eslint-disable-line no-console
+      await deleteTrigger({ wsId }).unwrap();
       dispatch(setLoading(false));
     } catch (err) {
       if (!isKBaseBaseQueryError(err)) {

src/index.test.tsx

@@ -1,7 +1,24 @@
 import { render } from '@testing-library/react';
 import Root from '.';
 
+const consoleInfo = jest.spyOn(console, 'info');
+// This mockImplementation supresses console.info calls.
+// eslint-disable-next-line @typescript-eslint/no-empty-function
+consoleInfo.mockImplementation(() => {});
+
 describe('Europa...', () => {
+  afterAll(() => {
+    consoleInfo.mockRestore();
+  });
+
+  afterEach(() => {
+    consoleInfo.mockClear();
+  });
+
+  beforeEach(() => {
+    consoleInfo.mockClear();
+  });
+
   test('exists.', () => {
     const { container } = render(<Root />);
     expect(container).toBeTruthy();