Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URO-28, URO-126, URO-127, URO-142: Fixed logout, authed collections, aligned topbar, created canonical build configuration file. #119

Merged
merged 12 commits into from
Oct 24, 2023

Conversation

dauglyon
Copy link
Collaborator

@dauglyon dauglyon commented Oct 12, 2023

  • URO-28: Align TopBar to mockup (presentation and accessibility)
    • Top bar appears as in mockup
    • Top bar has hamburger menu and user account menu
    • Top bar shows KBase logo and environment tag
    • Top bar elements are accessible by voiceover.
  • URO-126: Fix login and token issues
    • Update legacy kbase-ui to redirect to a better target after login
    • Investigate a better strategy for dealing with different API auth schemes, I.e. not sending the token/token-cookie if it is not valid/undefined. Right now issues are caused
      • on unauthed pages
      • if a token expires while a user is on the page
    • Show logged out state properly in the topbar
    • Add auth check to collections and any other pages missing it
  • URO-127: Logout support
    • Enable logging out without waiting for the heat death of the universe 🌌 .
  • URO-142: Create canonical build configuration JSON file.
    • Implement in such a way that discourages the use of other build configuration.
    • File may be imported and used at build time to control how the app behaves.
    • Answer the following questions:
      • How does the app import the build configuration at build time? (load into environment variables in build_deploy.sh.)
      • How may the app access the build configuration at runtime? (Environment variables.)
      • How does the app get the URL of the auth API and other services? (Environment variables.)

@dauglyon dauglyon requested a review from dakotablair October 12, 2023 19:36
@dauglyon dauglyon changed the title Fixed auth, added login, authed collections, aligned topbar Fixed logout, added login, authed collections, aligned topbar Oct 12, 2023
@dauglyon dauglyon changed the title Fixed logout, added login, authed collections, aligned topbar Fixed logout, authed collections, aligned topbar Oct 12, 2023
@dakotablair dakotablair changed the title Fixed logout, authed collections, aligned topbar URO-28, URO-126, URO-127: Fixed logout, authed collections, aligned topbar Oct 12, 2023
@dakotablair dakotablair changed the title URO-28, URO-126, URO-127: Fixed logout, authed collections, aligned topbar URO-28, URO-126, URO-127, URO-142: Fixed logout, authed collections, aligned topbar, created canonical build configuration file. Oct 17, 2023
@dakotablair dakotablair mentioned this pull request Oct 24, 2023
20 tasks
@dakotablair dakotablair merged commit 05a2c42 into main Oct 24, 2023
4 checks passed
@dakotablair dakotablair deleted the top-bar-complete branch October 24, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants