-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs #724
Build docs #724
Conversation
@@ -980,7 +980,7 @@ module Workspace { | |||
UnspecifiedObject data - The object's data. | |||
object_metadata metadata - Metadata for object retrieved/ | |||
|
|||
@deprecated Workspaces.ObjectData | |||
@deprecated Workspace.ObjectData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, it's only the spec... not a proper code file!
} | ||
include "**/workspace/*.java" | ||
exclude "**/workspace/WorkspaceServer.java" | ||
include "**/common/service/Tuple*.java" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ialarmedalien I know you laboriously copied over all the options from ant in your PR, but frankly I have no idea why they were there in the first place or if they're needed. The docs without them look fine to me so in the interests of simplicity I left them out. If we find we need them in the future it's easy enough to put them back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you didn't just reuse the code that I'd already written, esp since I laboriously tested it to ensure that it generated the same stuff. Also IMO it would have made more sense to start by building the jars, then the wars, then the docs, rather than going at things the other way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need the docs for the war and the shadow jar, which is why I'm doing them first
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-gradle2 #724 +/- ##
==============================================
Coverage 87.74% 87.74%
Complexity 5330 5330
==============================================
Files 228 228
Lines 17635 17635
Branches 2569 2569
==============================================
Hits 15473 15473
Misses 1700 1700
Partials 462 462 |
The java common UObject class needs those links, but not the workspace docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ialarmedalien should take a look as well!
No description provided.