Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs #724

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Build docs #724

merged 2 commits into from
Apr 4, 2024

Conversation

MrCreosote
Copy link
Member

No description provided.

@@ -980,7 +980,7 @@ module Workspace {
UnspecifiedObject data - The object's data.
object_metadata metadata - Metadata for object retrieved/

@deprecated Workspaces.ObjectData
@deprecated Workspace.ObjectData
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's only the spec... not a proper code file!

}
include "**/workspace/*.java"
exclude "**/workspace/WorkspaceServer.java"
include "**/common/service/Tuple*.java"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ialarmedalien I know you laboriously copied over all the options from ant in your PR, but frankly I have no idea why they were there in the first place or if they're needed. The docs without them look fine to me so in the interests of simplicity I left them out. If we find we need them in the future it's easy enough to put them back in

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you didn't just reuse the code that I'd already written, esp since I laboriously tested it to ensure that it generated the same stuff. Also IMO it would have made more sense to start by building the jars, then the wars, then the docs, rather than going at things the other way around.

Copy link
Member Author

@MrCreosote MrCreosote Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need the docs for the war and the shadow jar, which is why I'm doing them first

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #724 (5d9b354) into dev-gradle2 (23a2657) will not change coverage.
Report is 2 commits behind head on dev-gradle2.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff               @@
##             dev-gradle2     #724   +/-   ##
==============================================
  Coverage          87.74%   87.74%           
  Complexity          5330     5330           
==============================================
  Files                228      228           
  Lines              17635    17635           
  Branches            2569     2569           
==============================================
  Hits               15473    15473           
  Misses              1700     1700           
  Partials             462      462           

build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
The java common UObject class needs those links, but not the workspace
docs
Copy link
Collaborator

@Xiangs18 Xiangs18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ialarmedalien should take a look as well!

@MrCreosote MrCreosote merged commit 218f09c into kbase:dev-gradle2 Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants