Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commit to status() method & build #733

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

MrCreosote
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #733 (9b494eb) into dev-gradle2 (cceb096) will decrease coverage by 0.03%.
Report is 8 commits behind head on dev-gradle2.
The diff coverage is 58.33%.

Additional details and impacted files
@@                Coverage Diff                @@
##             dev-gradle2     #733      +/-   ##
=================================================
- Coverage          87.77%   87.75%   -0.03%     
- Complexity          5332     5333       +1     
=================================================
  Files                228      229       +1     
  Lines              17635    17647      +12     
  Branches            2589     2591       +2     
=================================================
+ Hits               15479    15486       +7     
- Misses              1698     1701       +3     
- Partials             458      460       +2     


private static final String COMMIT_FILE_NAME = "gitcommit";

static {
Copy link
Collaborator

@Xiangs18 Xiangs18 Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is static {} different from static keyword before var or method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A static block runs when the class is imported for the first time. A static variable or method are class variables / methods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense now!!

Copy link
Collaborator

@Xiangs18 Xiangs18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCreosote MrCreosote merged commit 26742b9 into dev-gradle2 Apr 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants