TASK-1203 Use default AbstractHandleConstants.pm #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set off namespace log messages with quotes
|
Feel free to review but please let me merge, so I can deploy and make sure it works. I will probably do that on Friday. |
kkellerlbl
commented
Apr 27, 2018
| @@ -29,7 +29,7 @@ endif | |||
|
|
|||
| SERVICE_PSGI = $(SERVICE_NAME).psgi | |||
| NAMESPACE = KBH | |||
| TPAGE_ARGS = --define kb_runtime=$(RUNTIME) --define kb_runas_user=$(SERVICE_USER) --define kb_top=$(TARGET) --define kb_service_name=$(SERVICE_NAME) --define kb_service_config_stanza=$(SERVICE_CONFIG) --define kb_service_dir=$(SERVICE_DIR) --define kb_service_port=$(SERVICE_PORT) --define kb_psgi=$(SERVICE_PSGI) --define handle_namespace=$(NAMESPACE) | |||
| TPAGE_ARGS = --define kb_runtime=$(RUNTIME) --define kb_runas_user=$(SERVICE_USER) --define kb_top=$(TARGET) --define kb_service_name=$(SERVICE_NAME) --define kb_service_config_stanza=$(SERVICE_CONFIG) --define kb_service_dir=$(SERVICE_DIR) --define kb_service_port=$(SERVICE_PORT) --define kb_psgi=$(SERVICE_PSGI) | |||
There was a problem hiding this comment.
This may be mostly cosmetic. I think the default may be defined in the build, and it's definitely explicitly set in the gitlab config (at least for CI).
| @@ -32,7 +32,7 @@ Log::Log4perl->easy_init($DEBUG); | |||
| use Bio::KBase::HandleServiceConstants 'handleNameSpace'; | |||
|
|
|||
| our $namespace = handleNameSpace; | |||
| INFO "pid $$ using $namespace as the default handle namespace"; | |||
| INFO "pid $$ using '$namespace' as the default handle namespace"; | |||
There was a problem hiding this comment.
The changes in this file are just for better logging, setting off the namespace in quotes, so that if it's undefined, we see '' instead of just whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed handle namespace from tpage arguments
Set off namespace log messages with quotes