Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomField::listNames() method as replacement for CustomField::listing() #408

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jun 28, 2024

Refs #338.

@Art4 Art4 added this to the v2.7.0 milestone Jun 28, 2024
@Art4 Art4 self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (b118039) to head (f4bd056).

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #408   +/-   ##
=========================================
  Coverage     98.49%   98.49%           
- Complexity      615      619    +4     
=========================================
  Files            29       29           
  Lines          1856     1866   +10     
=========================================
+ Hits           1828     1838   +10     
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 marked this pull request as ready for review June 28, 2024 11:53
@Art4 Art4 requested a review from kbsali June 28, 2024 11:53
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Art4 Art4 merged commit 35bb710 into kbsali:v2.x Jun 28, 2024
12 checks passed
@Art4 Art4 deleted the add-customfield-listnames branch June 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants