Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-windows): rm '\\?\' in windows path. #410

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Fix(kclvm-windows): rm '\\?\' in windows path. #410

merged 4 commits into from
Feb 13, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #379

2. What is the scope of this PR (e.g. component or file name):

kclvm-windows.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

rm '\?' in windows path for 'cl.exe'.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the windows Only for windows. label Feb 13, 2023
@zong-zhe zong-zhe added this to the v0.4.5 Release milestone Feb 13, 2023
@zong-zhe zong-zhe self-assigned this Feb 13, 2023
Peefy

This comment was marked as duplicate.

@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4163141337

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.7%) to 61.863%

Totals Coverage Status
Change from base Build 4162193986: -28.7%
Covered Lines: 21472
Relevant Lines: 34709

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Feb 13, 2023

LGTM

Need more unit tests on \\?

NeverRaR
NeverRaR previously approved these changes Feb 13, 2023
@Peefy Peefy self-requested a review February 13, 2023 10:04
@zong-zhe zong-zhe dismissed stale reviews from Peefy and NeverRaR via de36678 February 13, 2023 10:25
Peefy
Peefy previously approved these changes Feb 13, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NeverRaR
NeverRaR previously approved these changes Feb 13, 2023
@zong-zhe zong-zhe dismissed stale reviews from NeverRaR and Peefy via fd6442e February 13, 2023 11:54
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 972e37f into kcl-lang:main Feb 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
windows Only for windows.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants