Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-win): install plugins for win. #429

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix(kclvm-win): install plugins for win. #429

merged 1 commit into from
Mar 2, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Mar 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#379

2. What is the scope of this PR (e.g. component or file name):

kclvm-windows

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added bug Something isn't working windows Only for windows. labels Mar 2, 2023
@zong-zhe zong-zhe added this to the v0.4.6 Release milestone Mar 2, 2023
@zong-zhe zong-zhe self-assigned this Mar 2, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2023

Pull Request Test Coverage Report for Build 4310693296

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.0%) to 62.577%

Totals Coverage Status
Change from base Build 4250412496: -28.0%
Covered Lines: 23318
Relevant Lines: 37263

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b702678 into kcl-lang:main Mar 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working windows Only for windows.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants