Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PreTest]The checksum check of the three-party dependencies #404

Closed
wants to merge 1 commit into from

Conversation

vinayakjaas
Copy link

@vinayakjaas vinayakjaas commented Jul 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #394 ",.):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@vinayakjaas
Copy link
Author

Hey @Peefy ,@zong-zhe,@AkashKumar7902 I've opened a pull request that includes detailed documentation regarding the checksum check for third-party dependencies. I've put significant effort into designing this, but I would greatly appreciate your review and any necessary modifications.
Please note that the implementation may not be complete yet, as I am still exploring codebase to find some additional approaches to address the issue. I’m happy to make further changes based on your feedback.

@vinayakjaas vinayakjaas marked this pull request as ready for review July 27, 2024 07:31
@zong-zhe
Copy link
Contributor

Hi @vinayakjaas 😃

Split the different jobs into their own PR and associate them with the corresponding issues.

@vinayakjaas vinayakjaas force-pushed the preTest branch 2 times, most recently from 2af8d52 to 74f9282 Compare July 30, 2024 09:38
@vinayakjaas
Copy link
Author

Hey @zong-zhe, I have separated both pull requests as requested. Could you please go through and review them

@Peefy
Copy link
Contributor

Peefy commented Aug 1, 2024

@zong-zhe Could you help review it?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10160038561

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.674%

Totals Coverage Status
Change from base Build 10137817925: 0.0%
Covered Lines: 3066
Relevant Lines: 7728

💛 - Coveralls

@vinayakjaas
Copy link
Author

Hi @zong-zhe , please review this PR If you find any modifications are needed, please let me know, and I'll be happy to make the necessary changes.

@Peefy
Copy link
Contributor

Peefy commented Aug 14, 2024

cc @zong-zhe Could you help review it?

@zong-zhe
Copy link
Contributor

Hi @vinayakjaas 😄

Try to add a separate module Checker to complete this part of the work, including three-party dependency name check, version number check and sum check.

@zong-zhe zong-zhe closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LFT Term 3]: The checksum check of the three-party dependencies
4 participants