-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/python sync actions #181
Conversation
…on specific files
Jo takhle je to super! Diky moc! Jinak curl akce potrebuje curl command v Jdu tam hodit aktualni verzi a zatim budeme testovat oproti tomuhle tagu |
5946efe
to
0b11406
Compare
@AdamVyborny jeste koukam, ze ten build trva fakt mega dlouho, asi kvuli tem dodatecnym instalacim, mozna by stalo za ten image dostat na dockerhub, nebo nejak cachovat jestli to jde |
@davidesner něco zkusím: 013df8c |
013df8c
to
b054d5d
Compare
b054d5d
to
57ca6ff
Compare
@davidesner to by asi mohlo fungovat. Ale je tam klíč v tý cache na commit s fallbackem na Dockerfile hash. Takže pokud přidáš něco do requirments.txt, tak se to asi neinvaliduje. To by se muselo nějak domazlit ještě. |
@AdamVyborny z nejakyho zahadnyho duvodu se spousti run akce misto te co volam. Netusis cim to muze byt? response:
|
@davidesner ta akce musí být v configu:
|
@AdamVyborny tak pry to takhle ma byt https://app.swaggerhub.com/apis/odinuv/sync-actions/1.1.2#/default |
…e/python-sync-actions-requests-list # Conflicts: # python-sync-actions/src/component.py
52bb982
to
eca1716
Compare
b0b2d9c
to
7cd0074
Compare
7cd0074
to
20fc680
Compare
2fc0783
to
3af233f
Compare
8f0a542
to
65d493a
Compare
6742dac
to
c723405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! the next step can be to add more examples/tests calls to the mock server, like in the original component
Jen aby procházelo CI je potřeba dát nějaký funkční config sem: https://github.com/keboola/generic-extractor/blob/5946efef1f6da2b10c732c01336b0aa316de394d/tests/phpunit/data/syncAction/config.json a pak tady upravit assert podle toho, co to má vracet:
generic-extractor/tests/phpunit/MockExecutionTest.php
Line 71 in 5946efe
logger.ERROR: Process failed to start. Error output: cURL command not provided [] []\n
A když tam dám třeba tu akci
test_request
, tak to zas vrací not implemented.Každopádně, takhle by vám to zatím mohlo stačit pro nějaký laborování ne?