Skip to content

Commit

Permalink
Change InitialCooldownPeriod from int32 to *int32 (#6424)
Browse files Browse the repository at this point in the history
Signed-off-by: Zbynek Roubalik <[email protected]>
  • Loading branch information
zroubalik authored Dec 16, 2024
1 parent 110c93c commit 99c3b9c
Show file tree
Hide file tree
Showing 14 changed files with 213 additions and 215 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ New deprecation(s):

### Breaking Changes

- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
- Change `InitialCooldownPeriod` from `int32` to `*int32` ([#6423](https://github.com/kedacore/keda/issues/6423))

### Other

Expand Down
4 changes: 2 additions & 2 deletions apis/keda/v1alpha1/scaledobject_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ type ScaledObjectSpec struct {
// +optional
PollingInterval *int32 `json:"pollingInterval,omitempty"`
// +optional
InitialCooldownPeriod *int32 `json:"initialCooldownPeriod,omitempty"`
// +optional
CooldownPeriod *int32 `json:"cooldownPeriod,omitempty"`
// +optional
IdleReplicaCount *int32 `json:"idleReplicaCount,omitempty"`
Expand All @@ -101,8 +103,6 @@ type ScaledObjectSpec struct {
Triggers []ScaleTriggers `json:"triggers"`
// +optional
Fallback *Fallback `json:"fallback,omitempty"`
// +optional
InitialCooldownPeriod int32 `json:"initialCooldownPeriod,omitempty"`
}

// Fallback is the spec for fallback options
Expand Down
5 changes: 5 additions & 0 deletions apis/keda/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/metricsservice/api/metrics.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/metricsservice/api/metrics_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 99c3b9c

Please sign in to comment.