chore: update golangci-lint setup and Makefile integration (#6532)

Signed-off-by: Zbynek Roubalik <[email protected]>

.github/workflows/pr-validation.yml

@@ -150,8 +150,6 @@ jobs:
       - uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
         with:
           go-version: "1.23"
-      - name: Get golangci
-        run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.63.4
       - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
 
   trivy-scan:

.pre-commit-config.yaml

@@ -44,8 +44,7 @@ repos:
       entry: "bash hack/validate-changelog.sh"
       pass_filenames: false
     - id: golangci-lint
-      language: golang
+      language: system
       name: Run golangci against the code
-      entry: golangci-lint run
-      types: [go]
+      entry: make golangci
       pass_filenames: false

Makefile

@@ -46,6 +46,8 @@ else
 GOBIN=$(shell go env GOBIN)
 endif
 
+GOPATH:=$(shell go env GOPATH)
+
 GO_BUILD_VARS= GO111MODULE=on CGO_ENABLED=$(CGO) GOOS=$(TARGET_OS) GOARCH=$(ARCH)
 GO_LDFLAGS="-X=github.com/kedacore/keda/v2/version.GitCommit=$(GIT_COMMIT) -X=github.com/kedacore/keda/v2/version.Version=$(VERSION)"
 
@@ -54,6 +56,8 @@ COSIGN_FLAGS ?= -y -a GIT_HASH=${GIT_COMMIT} -a GIT_VERSION=${VERSION} -a BUILD_
 # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
 ENVTEST_K8S_VERSION = 1.32
 
+GOLANGCI_VERSION:=1.63.4
+
 # Setting SHELL to bash allows bash commands to be executed by recipes.
 # This is a requirement for 'setup-envtest.sh' in the test target.
 # Options are set to exit when a recipe line exits non-zero or a piped command fails.
@@ -146,7 +150,12 @@ fmt: ## Run go fmt against code.
 vet: ## Run go vet against code.
 	go vet ./...
 
+HAS_GOLANGCI_VERSION:=$(shell $(GOPATH)/bin/golangci-lint version --format=short)
+.PHONY: golangci
 golangci: ## Run golangci against code.
+ifneq ($(HAS_GOLANGCI_VERSION), $(GOLANGCI_VERSION))
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v$(GOLANGCI_VERSION)
+endif
 	golangci-lint run
 
 verify-manifests: ## Verify manifests are up to date.

apis/keda/v1alpha1/scaledobject_webhook.go

@@ -190,7 +190,6 @@ func verifyReplicaCount(incomingSo *ScaledObject, action string, _ bool) error {
 	return nil
 }
 
-//nolint:unparam
 func verifyFallback(incomingSo *ScaledObject, action string, _ bool) error {
 	err := CheckFallbackValid(incomingSo)
 	if err != nil {