Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks the prometheus metrics to adhere to best practices #5174

Closed

fixing tests

388be0f
Select commit
Loading
Failed to load commit list.
Closed

Reworks the prometheus metrics to adhere to best practices #5174

fixing tests
388be0f
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-04-10 17:17:35 ago

3 / 4 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
I have verified that my change is according to the deprecations & breaking changes policy Completed
Tests have been added Incomplete
Changelog has been updated and is aligned with our changelog requirements Completed
Commits are signed with Developer Certificate of Origin (DCO - learn more) Completed
Add an entry in our changelog in alphabetical order and link related issue Incomplete
Update the documentation, if needed Incomplete
Add unit & e2e tests for your changes Incomplete
GitHub checks are passing Incomplete
Is the DCO check failing? Here is how you can fix DCO issues Incomplete
Our contribution guide Incomplete
metrics are covered by e2e tests, so you have to update this file adding the new metrics Incomplete
you've already done all the things related with the deprecation policy (after adding the change to the description), next steps have to be done once this is merged (opening issues, discussion, etc) Incomplete
reworded the totals to count as preferred by Otel, and deprecated the old ones. Incomplete
added the "s" unit to the latency metrics Incomplete
added a test for the unit being recorded, and 500 milliseconds should show as 0.5 Incomplete