Multiple minor corrections

[rickbrouwer]

This PR is a collection of some minor corrections:

• Fix namespace spelling error
• Remove period so all messages have no period
• Remove deprecated test in Pulsar scaler test
• Remove unnecessary optional when default is set in various scalers
• Adjust the OpenSSF Scorecard badge link so the Clomonitor regexp sees it

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

[zroubalik]

Remove unnecessary optional when default is set in various scalers

TBH I not sure about this, we might use these tags to generate schema and we would like to capture the optional there. CC @wozniakjan

[rickbrouwer]

Remove unnecessary optional when default is set in various scalers

TBH I not sure about this, we might use these tags to generate schema and we would like to capture the optional there. CC @wozniakjan

That's good to know indeed. From TypedConfig optional doesn't do much if it has also a default since a value is set from the default if it's not filled.
Reference:

keda/pkg/scalers/scalersconfig/typed_config.go

Lines 198 to 201 in 29400ed

	if !exists && params.Default != "" {
	exists = true
	valFromConfig = params.Default
	}

If there is a good reason, I might even have to make corrections the other way (so add optional where it hasn't been done because of a default)

[wozniakjan]

TBH I not sure about this, we might use these tags to generate schema and we would like to capture the optional there

my logic was that a field with default is always inherently optional. Default works in a way that when the field is not specified in trigger metadata, KEDA will use the default value. @zroubalik, @rickbrouwer can you think of a situation where a field that is not optional but has default value is useful?

If there is a good reason, I might even have to make corrections the other way

I won't object, but I am leaning towards your current approach where the extra optional are removed. Imho optional is redundant for fields with default.

[rickbrouwer]

I believe that if a field has a default, it is also optional. After all, if the field is mandatory and has a default value and you want this value, you can choose not to specify this value. That automatically makes the field optional.

I would also like to choose my current approach.

[JorTurFer]

Nice job! Apart from the discussion about optional, just a small nit

[zroubalik]

@rickbrouwer could you please fix the conflict?

[zroubalik]

/run-e2e
Update: You can check the progress here

[rickbrouwer]

/run-e2e Update: You can check the progress here

The e2e seems to me to be failing on a number of unstable existing tests. These also seem to be failing on the nightly-e2e test.

[wozniakjan]

/run-e2e internals|splunk|solr|solace|redis|rabbitmq|pulsar|prometheus|postgresql|mongo|etcd|couchdb|cassandra|beanstalkd|aws_cloudwatch|artemis|activemq

The e2e seems to me to be failing on a number of unstable existing tests

yeah, a good number of tests that are unaffected by the changes. I "crafted" a regexp to trigger only relevant modified scaler tests + internal suite (just to be sure) to skip the flaky azure and other tests as those were not touched
Update: You can check the progress here

[wozniakjan]

lgtm, thank you!

let's see if the e2es pass now