This repository has been archived by the owner on May 22, 2023. It is now read-only.
Update design to Factory/Vendor #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced Keep Vendor contract according to Keep RFC 12. A vendor is a smart contract with which the application interacts to obtain the new instance of a keep of the given type backed by enough stakers so that all operations on the created keep can go smoothly. Vendor interacts with keep factories choosing the one most recent if it is backed by enough stakers. Each vendor is a service contract and does not have to be sanctioned by stakers. Each vendor can operate on several versions of keep factory to allow for a smooth upgrade process.
Implemented Keep Registry contract according to Keep RFC 12 The keep registry serves the role of the master list and tracks sanctioned staking contracts, operator contracts (including keep factories) and vendors. It ensures that only approved contracts are used. A new type of keep can be added without upgradeable registry.
This was referenced Jul 16, 2019
Truffle is catching unexpected errors in test so no need to declare catches for functions execution.
liamzebedee
suggested changes
Jul 16, 2019
|
@liamzebedee ready for a next round. |
liamzebedee
suggested changes
Jul 18, 2019
pdyraga
reviewed
Jul 18, 2019
pdyraga
reviewed
Jul 18, 2019
pdyraga
reviewed
Jul 18, 2019
pdyraga
suggested changes
Jul 23, 2019
liamzebedee
previously requested changes
Jul 23, 2019
This reverts commit 99e1529.
|
@liamzebedee Can you please take a look if you are happy with the changes here and approve if you are? We'll need to coordinate this change with |
pdyraga
approved these changes
Jul 25, 2019
pdyraga
dismissed
liamzebedee’s stale review
Liam is not able to provide review here ATM, all this comments were addressed as requested so I am dismissing this review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated architecture to reflect proposal from RFC 12.
Introduced vendor contract to hold references to the factory.
Updated keep registry to hold references to vendors for given keep types.
Closes #41