Feat/taproot verify #289
Merged
Feat/taproot verify #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jeanmichel7 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
|
It's probably best to go ahead and set up the caches, yeah, nice work so far! Let me know when you're ready, and I can do a deeper review. Thanks! |
|
Hey @Jeanmichel7 how is the progress on the PR? I would like to merge it soon, because it would be used in the Bitcoin inscriptions contracts. |
2 tasks
lana-shanghai
pushed a commit
that referenced
this pull request
Jan 16, 2025
<!-- enter the gh issue after hash --> - [X] follows contribution [guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md) - [X] code change includes tests Adding Schnorr signatures verification. Works alongside with #289 --------- Co-authored-by: j1mbo64 <[email protected]>
|
@lana-shanghai There are still a few TODOs for SigVerify, but as you seem to be in a hurry, there's already enough for a review. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lana-shanghai
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calc_hash_inputs_amount and calc_hash_input_scripts in SigHashMidstateTrait::new(tx) for taproot
I think it's essential to set up the cache in order to be able to retrieve the utxos of the inputs processed in the calcHashInputAmounts and calcHashInputScript functions.
https://github.com/btcsuite/btcd/blob/master/txscript/hashcache.go#L157
Before going any further, I'd like your opinion