Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump controller-runtime, k8s/golang/workflow-controller version #96

Merged
merged 34 commits into from
Feb 12, 2022
Merged

bump controller-runtime, k8s/golang/workflow-controller version #96

merged 34 commits into from
Feb 12, 2022

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Feb 7, 2022

Signed-off-by: jhu02 [email protected]

Fixes #93

@ccfishk ccfishk requested a review from a team as a code owner February 7, 2022 18:29
@ccfishk ccfishk mentioned this pull request Feb 7, 2022
Closed
@ccfishk ccfishk requested a review from shailshah9 February 7, 2022 18:36
kevdowney
kevdowney reviewed Feb 7, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@kevdowney
Copy link
Collaborator

We need to verify this runs tests, please post unit-tests results make test

kevdowney
kevdowney reviewed Feb 7, 2022
View reviewed changes
main.go Show resolved Hide resolved
kevdowney
kevdowney reviewed Feb 7, 2022
View reviewed changes
main.go Show resolved Hide resolved
kevdowney
kevdowney reviewed Feb 7, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
shailshah9
shailshah9 reviewed Feb 7, 2022
View reviewed changes
Dockerfile Show resolved Hide resolved
config/crd/patches/cainjection_in_addons.yaml Outdated Show resolved Hide resolved
config/crd/patches/webhook_in_addons.yaml Outdated Show resolved Hide resolved
kevdowney
kevdowney requested changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restrict Workflow watcher to the controller namespace.

jhu02 and others added 2 commits February 7, 2022 17:46
kevdowney
kevdowney requested changes Feb 8, 2022
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
controllers/addon_controller.go Outdated Show resolved Hide resolved
@ccfishk ccfishk self-assigned this Feb 8, 2022
ccfish2 and others added 2 commits February 7, 2022 18:42
jhu02 added 2 commits February 11, 2022 11:52
start workflowinformers
86a35bc 
Signed-off-by: jhu02 <[email protected]>
informers changes
d645c8d 
Signed-off-by: jhu02 <[email protected]>
@ccfishk ccfishk requested a review from kevdowney February 11, 2022 20:17
@ccfishk ccfishk requested a review from kevdowney February 11, 2022 20:28
cleanup++
985848b 
Signed-off-by: jhu02 <[email protected]>
@ccfishk ccfishk requested a review from kevdowney February 12, 2022 00:18
optimization
d577fe9 
Signed-off-by: jhu02 <[email protected]>
@ccfishk ccfishk requested a review from kevdowney February 12, 2022 01:26
@ccfishk ccfishk requested a review from kevdowney February 12, 2022 15:32
kevdowney
kevdowney approved these changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let’s evaluate after merge if we need more code coverage.

@kevdowney kevdowney merged commit ff34241 into master Feb 12, 2022
@kevdowney kevdowney deleted the upgrade-version branch February 12, 2022 18:59
@kevdowney kevdowney mentioned this pull request Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figo figo figo requested changes

@kevdowney kevdowney kevdowney approved these changes

@tekenstam tekenstam tekenstam left review comments

@shailshah9 shailshah9 Awaiting requested review from shailshah9

Assignees

@ccfishk ccfishk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies golang 1.7, argo and k8s api's 1.21
6 participants
@ccfishk @kevdowney @figo @tekenstam @shailshah9 @ccfish2