Cleanup and renames #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps by lowering the dependency on CSS specific parts (like an interned list of CSS keywords) and attempts to create a more efficient way to create lower-case strings by using the bump allocator only when necessary.
keithamus
force-pushed
the
cleanup-and-renames
branch
from
1e70de5 to
c52ad1e
Compare
keithamus
force-pushed
the
cleanup-and-renames
branch
from
3c180a4 to
6b51d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another giant refactor:
hdx_atomcrate, instead opting to do interning on each node. This de-couples the lexer & parser from css the language itself.hdx_syntaxintohdx_lexeras it wasn't used outside of that.hdx_lexertocss_lexer.hdx_parsertocss_parse.css_lexer&css_parse.hdx_astintocss_parse.hdx_asttocss_ast- make it just for CSS (the original intent was forhdx_astto have multiple language ASTs, e.g.sass, but I think now we can add asass_astcrate instead).