Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nan to 1.8.0 to fix iojs 2.0.0 build #299

Merged
merged 1 commit into from
May 6, 2015
Merged

Update nan to 1.8.0 to fix iojs 2.0.0 build #299

merged 1 commit into from
May 6, 2015

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented May 5, 2015

There are some deprecation warnings in the build though...

Fixes #298

@nmccready
Copy link

bump

@MateusZitelli
Copy link

👍

@dhritzkiv
Copy link

👍 as well.

Suggestion: add iojs targets under node_js to the .travis.yml file:

node_js:
  - "0.8"
  - "0.10"
  - "0.12"
  - "iojs-v1.8.0"
  - "iojs-v2.0.0" 

So we can verify that it compiles and tests properly on iojs

@imyller
Copy link

imyller commented May 5, 2015

Referencing nodejs/node#1620

@gordalina
Copy link

Bump

@cesarandreu
Copy link

👍

@kkoopa
Copy link

kkoopa commented May 6, 2015

You want 1.8.4, not 1.8.0.

@imyller
Copy link

imyller commented May 6, 2015

Exactly, 1.8.4 not 1.8.0
My PR #300 for ~1.8 would have bumped to latest 1.8.4 (and then stayed with 1.8.x line), but node.bcrypt.js wants to use exact versions for some reason.

@gordalina
Copy link

👍 for 1.8.4

@topaxi
Copy link
Contributor Author

topaxi commented May 6, 2015

Updated all dependencies to the newest versions

@alanpurple
Copy link

+1

@gordalina
Copy link

You could also add in .travis.yml iojs-v1 and iojs-v2

@defunctzombie
Copy link
Collaborator

@kkoopa Do you think this is ready to go? no more nan updates that will need to be made immediately?

@kkoopa
Copy link

kkoopa commented May 6, 2015

Well, according to current plans, io.js 3.0 with V8 4.3 should come out in a month or so. This will require NAN 2.0, which will have breaking changes to accommodate the Maybe monads introduced in V8 4.3. So you'll have to do some rewriting then, but there is no reason not to do this simple upgrade in the meantime.

On May 6, 2015 9:08:49 PM EEST, Roman Shtylman [email protected] wrote:

@kkoopa Do you think this is ready to go? no more nan updates that will
need to be made immediately?


Reply to this email directly or view it on GitHub:
#299 (comment)

defunctzombie added a commit that referenced this pull request May 6, 2015
Update nan to 1.8.0 to fix iojs 2.0.0 build
@defunctzombie defunctzombie merged commit d363f15 into kelektiv:master May 6, 2015
@imyller
Copy link

imyller commented May 6, 2015

Business as usual and an infinite loop :)

V8 evolves. NAN updates accordingly. Packages update NAN dependencies. And then we start all over again.

@nmccready
Copy link

Working thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bcrypt fails to build on io.js 2.0.0
10 participants