-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nan to 1.8.0 to fix iojs 2.0.0 build #299
Conversation
bump |
👍 |
👍 as well. Suggestion: add iojs targets under node_js:
- "0.8"
- "0.10"
- "0.12"
- "iojs-v1.8.0"
- "iojs-v2.0.0" So we can verify that it compiles and tests properly on iojs |
Referencing nodejs/node#1620 |
Bump |
👍 |
You want 1.8.4, not 1.8.0. |
Exactly, 1.8.4 not 1.8.0 |
👍 for |
Updated all dependencies to the newest versions |
+1 |
You could also add in |
@kkoopa Do you think this is ready to go? no more nan updates that will need to be made immediately? |
Well, according to current plans, io.js 3.0 with V8 4.3 should come out in a month or so. This will require NAN 2.0, which will have breaking changes to accommodate the Maybe monads introduced in V8 4.3. So you'll have to do some rewriting then, but there is no reason not to do this simple upgrade in the meantime. On May 6, 2015 9:08:49 PM EEST, Roman Shtylman [email protected] wrote:
|
Update nan to 1.8.0 to fix iojs 2.0.0 build
Business as usual and an infinite loop :) V8 evolves. NAN updates accordingly. Packages update NAN dependencies. And then we start all over again. |
Working thank you! |
There are some deprecation warnings in the build though...
Fixes #298