Backport updates from the NAN version to N-API #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:hoek:20180212 Latest report for kelektiv/node.bcrypt.js: https://snyk.io/test/github/kelektiv/node.bcrypt.js
[Snyk Update] New fixes for 8 vulnerable dependency paths
Starting with Nan 2.9.0, we have the ability to propagate async context across async hops. Certain variants of Nan::Callback::Call are now deprecated to encourage context preserving. Here's a simple patch that fixes the deprecation warnings and properly propagates the async context across the async APIs exposed by this module. For more information see [1], [2]. [1]: https://github.com/nodejs/nan/blob/HEAD/doc/node_misc.md#nanasyncresource. [2]: https://nodejs.org/dist/latest-v9.x/docs/api/async_hooks.html#async_hooks_javascript_embedder_api
fix: propagate async context
Add support for 2b hashes
Allow to choose bcrypt minor version
* export a use function from lib/promises closes #478 the `use` function can be used to change the promise implementation that is used by the library
Make binaries libc aware
Upgrade node-pre-gyp to fix broken binary downloads
Added node 10 to Travis and Appveyor * conditional support for node v4 and v5 in travis.yml * conditional support for node v4 and v5 appveyor.yml
Typo fix in examples
Important proxy issues were fixed
Update node-pre-gyp to 0.11.0
readme: improve readability of version table
Automate release uploading from travis
deps: update nan
Change var to const in README for consistency
Fix appveyor.yml to generate artifacts in proper order
Update nan
Execute tests on Node.js 11
Update dependencies
Update nan
Fix gcc,nan & v8 deprecations
|
We need to rework this first. This shows some merge conflicts. |
|
How do you want proceed? |
|
Hi @agathver, |
|
We can skip Node 7. It's EOL |
fast-facts
pushed a commit
to fast-facts/node.bcrypt.js
that referenced
this pull request
Jun 17, 2022
Backport updates from the NAN version to N-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
with this PR I ported the updates introduced in the NAN version of the add-on to the N-API version.
Furthermore I added the support for node-pre-gyp as requested here: #513
This first effort on porting the add-on to N-API has the purpose to reduce the maintenance cost for developers as discussed here: #513
bcrypt is one of the most important native add-on and it is tracked by citgm, but in this issue seems that it will not work well in the future version of Node.js (v12) See: nodejs/node#25060
N-API could help to manage this kind of issues. In general using N-API maintainers do not take care of the changes that happens in V8 or node.
Please consider to review this PR and collaborate together to release this new version.