Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mock test dependency optional for Python > 3.3 #305

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Make mock test dependency optional for Python > 3.3 #305

merged 1 commit into from
Nov 8, 2023

Conversation

jelly
Copy link
Contributor

@jelly jelly commented Nov 8, 2023

Since Python 3.3 unittest.mock is available as a build in module.

Tox still mentions mock, but I have no idea how to make that optional.

@jelly
Make mock test dependency optional for Python > 3.3
3baf0c3 
Since Python 3.3 unittest.mock is available as a build in module.
skorokithakis
skorokithakis approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@skorokithakis skorokithakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skorokithakis skorokithakis merged commit 52358ac into keleshev:master Nov 8, 2023
@jelly jelly deleted the unittest-mock branch November 9, 2023 08:23
@mutricyl mutricyl mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorokithakis skorokithakis skorokithakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @skorokithakis