Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is show eg #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Is show eg #31

wants to merge 5 commits into from

Conversation

yinsong19
Copy link

yd -c 颜色可配置
yd -e || 例句是否显示

@kenshinji
Copy link
Owner

@shiguangpaoqini ，谢谢你的PR，几点建议：

  1. 为什么要加这样一个feature？
  2. 能否针对你添加的几个参数给出相应的sample，加入到README.md里面？
  3. 貌似build挂了，能否请先补全或修改相应的tests使得build通过再提PR？

@yinsong19
Copy link
Author

手动修改配置文件太不友好了，
学校放假了再改吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinsong19 @kenshinji