Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fenced Doc-strings #782

Closed
abheesht17 opened this issue Feb 26, 2023 · 5 comments
Closed

Fix Fenced Doc-strings #782

abheesht17 opened this issue Feb 26, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:Bug Something isn't working

Comments

@abheesht17
Copy link
Collaborator

abheesht17 commented Feb 26, 2023

Ran the fenced doc-string tests, and bumped into some test failures: https://p.ip.fi/JWSr.

To fix this issue, do the following:

After you are done making these changes, run this Colab to check whether the tests pass: https://colab.research.google.com/drive/1JGxvuqga-uT7dYFggmzIoB12nrWO4xYv?usp=sharing.

@abheesht17 abheesht17 added type:Bug Something isn't working good first issue Good for newcomers stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues labels Feb 26, 2023
@abheesht17
Copy link
Collaborator Author

@atharvapurdue, would you like to take this up?

@abheesht17
Copy link
Collaborator Author

@mattdangerw, can we set this up as a weekly cron job? Won't have to manually run tests again and again.

@atharvapurdue
Copy link
Contributor

Sure @abheesht17 , I would like to take this up if it is available. Looks like a good first issue! Thanks a lot!

@abheesht17
Copy link
Collaborator Author

Great, assigned the issue to you!

@mattdangerw
Copy link
Member

@abheesht17 yeah we absolutely do need to set up some sort of regularly scheduled testing that is not on each PR.

I would prefer a nightly test that runs every "extra large" test. Issue is that would probably need to be setup by me or @chenmoneygithub and we are both pretty swamped! But we should soon. Let me file an issue.

mattdangerw pushed a commit that referenced this issue Mar 3, 2023
* Fixed Fenced Doc-strings error

* Import from root library

* adding [MASK]

* remove num_head

* remove num_heads

* make segment_ids to default

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants