-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fenced Doc-strings #782
Comments
@atharvapurdue, would you like to take this up? |
@mattdangerw, can we set this up as a weekly cron job? Won't have to manually run tests again and again. |
Sure @abheesht17 , I would like to take this up if it is available. Looks like a good first issue! Thanks a lot! |
Great, assigned the issue to you! |
@abheesht17 yeah we absolutely do need to set up some sort of regularly scheduled testing that is not on each PR. I would prefer a nightly test that runs every "extra large" test. Issue is that would probably need to be setup by me or @chenmoneygithub and we are both pretty swamped! But we should soon. Let me file an issue. |
Ran the fenced doc-string tests, and bumped into some test failures: https://p.ip.fi/JWSr.
To fix this issue, do the following:
keras_nlp.tokenizers.byte_pair_tokenizer
,keras_nlp.tokenizers.sentence_piece_tokenizer
,keras_nlp.tokenizers.word_piece_tokenizer
to the list here: https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/tests/doc_tests/docstring_test.py#L106-L117.keras_nlp.models.AlbertTokenizer
instead of justAlbertTokenizer
.After you are done making these changes, run this Colab to check whether the tests pass: https://colab.research.google.com/drive/1JGxvuqga-uT7dYFggmzIoB12nrWO4xYv?usp=sharing.
The text was updated successfully, but these errors were encountered: