Simplify running KerasNLP with Keras 3 #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mattdangerw
commented
Nov 9, 2023
| _USE_KERAS_3 = detect_if_tensorflow_uses_keras_3() | ||
| if _USE_KERAS_3: | ||
| _MULTI_BACKEND = True | ||
| if not _USE_KERAS_3: |
There was a problem hiding this comment.
This is totally optional. We don't need to have it, but since we used to switch to keras core if KERAS_BACKEND was set, this seems like a useful signpost.
There was a problem hiding this comment.
This is good to have IMO!
fchollet
approved these changes
Nov 13, 2023
| _USE_KERAS_3 = detect_if_tensorflow_uses_keras_3() | ||
| if _USE_KERAS_3: | ||
| _MULTI_BACKEND = True | ||
| if not _USE_KERAS_3: |
There was a problem hiding this comment.
This is good to have IMO!
| raise ValueError( | ||
| "Lora only works with multi-backend Keras 3. Please set the " | ||
| "`KERAS_BACKEND` environment variable to use this API." | ||
| "Lora requires with Keras 3, and Keras 2 is installed. Please " |
mattdangerw
force-pushed
the
simplify-keras-3-support
branch
from
3cce43b to
7e4c66e
Compare
We should not land this until Keras 3, TensorFlow 2.15, and keras-nlp-nightly are released.
mattdangerw
force-pushed
the
simplify-keras-3-support
branch
from
7e4c66e to
e214d43
Compare
|
/gcbrun |
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
* Simplify running KerasNLP with Keras 3 We should not land this until Keras 3, TensorFlow 2.15, and keras-nlp-nightly are released. * Address comments * Tweaks * Add link * fix link
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
* Simplify running KerasNLP with Keras 3 We should not land this until Keras 3, TensorFlow 2.15, and keras-nlp-nightly are released. * Address comments * Tweaks * Add link * fix link
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
* Simplify running KerasNLP with Keras 3 We should not land this until Keras 3, TensorFlow 2.15, and keras-nlp-nightly are released. * Address comments * Tweaks * Add link * fix link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not land this until Keras 3 and TensorFlow 2.15 are released.
This deprecates any public use of
keras_core,keras_corebecomes an internal shim solely to backportskeras.opsto Keras 2. This updates our installation instructions for the Keras 3 world.