Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix t5 tokenizer expected output #1348

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix t5 tokenizer expected output #1348

merged 1 commit into from
Dec 6, 2023

Conversation

mattdangerw
Copy link
Member

I am not exactly sure how this was ever working

We had copied the bert output, t5 has a different tokenizer.

@mattdangerw
Fix t5 tokenizer expected output
8260749 
I am not exactly sure how this was ever working

We had copied the bert output, t5 has a different tokenizer.
@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw mattdangerw requested a review from nkovela1 December 6, 2023 02:36
nkovela1
nkovela1 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@nkovela1 nkovela1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think it didn't show up in our CI because it was marked large. LGTM!

@mattdangerw mattdangerw marked this pull request as ready for review December 6, 2023 18:09
@mattdangerw mattdangerw merged commit 6092213 into keras-team:master Dec 6, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkovela1 nkovela1 nkovela1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @nkovela1