Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preprocessor for the Mistral backbone #1385

Merged

Conversation

tirthasheshpatel
Copy link
Contributor

This PR adds a preprocessor for the keras_nlp.models.Mistral backbone.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple comments

keras_nlp/models/mistral/mistral_preprocessor.py Outdated Show resolved Hide resolved
keras_nlp/models/mistral/mistral_preprocessor_test.py Outdated Show resolved Hide resolved
@tirthasheshpatel
Copy link
Contributor Author

All tests passing, so merging. Will propose the 7B preset next.

@tirthasheshpatel tirthasheshpatel merged commit 89a77f0 into keras-team:master Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants