Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistral and electra tokenizer to match kaggle changes #1387

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mattdangerw
Copy link
Member

We are changing all tokenizer to store vocabularies via assets (and not in the config). This requires some changes to tokenizer so files state can be set after object creation.

We are changing all tokenizer to store vocabularies via assets (and
not in the config). This requires some changes to tokenizer so files
state can be set after object creation.
@mattdangerw mattdangerw requested a review from nkovela1 January 4, 2024 19:58
Copy link
Collaborator

@nkovela1 nkovela1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Matt

@mattdangerw mattdangerw merged commit f1ab62a into keras-team:master Jan 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants