Clean up class name and self in calls to super()
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 3135 [^1] simplified the syntax for `super()` in Python 3.0 from:
super(ClassName, self)
to the following very simple and equivalent [^2] syntax:
super()
The current Keras codebase already requires Python 3+.
This change simplifies the entire code base by cleaning up the remaining
explicit uses of the current class name and `self` and using the cleaner
`super()` syntax everywhere consistently.
Since the new syntax is intended to be a shorthand for the old syntax, this
change should have no semantic differences from before.
[^1]: https://peps.python.org/pep-3135/
[^2]: https://docs.python.org/3/library/functions.html#super
mbrukman
force-pushed
the
clean-up-super-call-python3
branch
from
11b0c18 to
3ba10ea
Compare
jbischof
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 3135 1 simplified the syntax for
super()in Python 3.0 from:to the following very simple and equivalent 2 syntax:
The current Keras codebase already requires Python 3+, and there's a mix of the two syntax formats above, sometimes both are used in a single file.
This change simplifies the entire code base by cleaning up the remaining explicit uses of the current class name and
selfand using the cleanersuper()syntax everywhere consistently.Since the new syntax is intended to be a shorthand for the old syntax, this change should have no semantic differences from before.
Footnotes
https://peps.python.org/pep-3135/ ↩
https://docs.python.org/3/library/functions.html#super ↩