-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up examples/ directory #637
Clean up examples/ directory #637
Conversation
It would be nice to keep some sort of minimal content in the README...
We should do some light renaming of the content in this directory and fix all import after renaming.
@chenmoneygithub do those renames look ok to you as well? |
Thanks mattdangerw, I add this to readme 👍🏻 |
This reverts commit 2c4603c.
Hey @chenmoneygithub can I make this changes, If those renames look ok ?
|
…EADME.md" This reverts commit bf9d4e2.
@ADITYADAS1999 thanks! This looks good! We will also need to update the README here -> https://github.com/keras-team/keras-nlp/blob/master/examples/bert/README.md to reflect the script renames. Should be a simpler find and replace. Also can we delete this section entirely? https://github.com/keras-team/keras-nlp/blob/master/examples/bert/README.md#evaluating-bert-with-glue. We are removing the script on this PR. |
what kind of changes should I change here in the docs? can you suggest little bit. |
In my opinion we have to remove this section, as we remove the |
Sure!
|
thanks mattdangerw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks mattdangerw for reviewing 😀 |
Clean up examples/ directory #573