Add FNet Preprocessor #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
reviewed
Jan 11, 2023
| super().__init__(proto=proto, **kwargs) | ||
|
|
||
| # Check for necessary special tokens. | ||
| cls_token = "[CLS]" |
There was a problem hiding this comment.
This is odd, they really mix special tokens styles like this?
I guess this is half BERT style, half sentencepiece defaults.
There was a problem hiding this comment.
Yeah, I verified it with HF's tokenizer output
Closed
mattdangerw
approved these changes
Jan 13, 2023
| - Pack the inputs together using a `keras_nlp.layers.MultiSegmentPacker`. | ||
| with the appropriate `"[CLS]"`, `"[SEP]"` and `"<pad>"` tokens. | ||
| - Construct a dictionary with keys `"token_ids"`, `"segment_ids"` and | ||
| `"padding_mask"`, that can be passed directly to |
There was a problem hiding this comment.
there is no "padding_mask" right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://colab.research.google.com/drive/1wd7ApfnTwS_xqa62Isdx3CGIZ95ixwxC?usp=sharing