Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the epsilon value #665

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Corrected the epsilon value #665

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f0b7d0
Corrected the epsilon value
soma2000-lang Jan 16, 2023
50441fc
Corrected the epsilon value
soma2000-lang Jan 16, 2023
1cf99ee
Corrected the epsilon value
soma2000-lang Jan 16, 2023
2754375
Corrected the epsilon value
soma2000-lang Jan 16, 2023
9255050
Corrected the epsilon value
soma2000-lang Jan 16, 2023
f9318b5
Update bert_backbone.py
soma2000-lang Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions keras_nlp/models/bert/bert_backbone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ def __init__(
x, approximate=True
),
dropout=dropout,
layer_norm_epilson=1e-12,
Copy link
Collaborator

@abheesht17 abheesht17 Jan 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @soma2000-lang. The tests are failing because epsilon has been misspelt. Could you please correct and push again? Thanks!

kernel_initializer=bert_kernel_initializer(),
name=f"transformer_layer_{i}",
)(x, padding_mask=padding_mask)
Expand Down