Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test test_output_mode_dict #20228

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix test test_output_mode_dict #20228

merged 2 commits into from
Sep 8, 2024

Conversation

AryazE
Copy link
Contributor

@AryazE AryazE commented Sep 7, 2024

There was a problem with checking the backend (the () were forgotten), and hence the condition always evaluated to False.

Copy link

google-cla bot commented Sep 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (cb6ece3) to head (7069740).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20228      +/-   ##
==========================================
- Coverage   82.12%   79.37%   -2.75%     
==========================================
  Files         501      501              
  Lines       47440    47440              
  Branches     8711     8711              
==========================================
- Hits        38958    37655    -1303     
- Misses       6570     8022    +1452     
+ Partials     1912     1763     -149     
Flag Coverage Δ
keras 79.22% <ø> (-2.76%) ⬇️
keras-jax 62.51% <ø> (-2.76%) ⬇️
keras-numpy 57.70% <ø> (-0.15%) ⬇️
keras-tensorflow 63.89% <ø> (-2.76%) ⬇️
keras-torch 62.56% <ø> (-2.75%) ⬇️
keras.applications ?
keras.applications-jax ?
keras.applications-numpy ?
keras.applications-tensorflow ?
keras.applications-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Sep 8, 2024
@fchollet fchollet merged commit f3a8594 into keras-team:master Sep 8, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants