Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inner op #20532

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Add inner op #20532

merged 6 commits into from
Nov 24, 2024

Conversation

IMvision12
Copy link
Contributor

Inner product of two arrays.

@fchollet

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (a93828a) to head (085e336).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20532      +/-   ##
==========================================
+ Coverage   82.11%   82.17%   +0.05%     
==========================================
  Files         515      515              
  Lines       47806    47956     +150     
  Branches     7490     7500      +10     
==========================================
+ Hits        39258    39409     +151     
+ Misses       6736     6734       -2     
- Partials     1812     1813       +1     
Flag Coverage Δ
keras 82.02% <95.55%> (+0.05%) ⬆️
keras-jax 65.11% <42.22%> (+0.05%) ⬆️
keras-numpy 60.11% <51.11%> (+0.07%) ⬆️
keras-tensorflow 66.09% <53.33%> (+0.05%) ⬆️
keras-torch 65.05% <55.55%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras/src/backend/tensorflow/numpy.py Outdated Show resolved Hide resolved
keras/src/ops/numpy.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please update the API files via sh shell/api_gen.sh. This will also fix CI.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 24, 2024
@fchollet fchollet merged commit 0078f24 into keras-team:master Nov 24, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 24, 2024
@IMvision12 IMvision12 deleted the inner branch November 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants