Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add command palette functionality to monaco #6944

Merged

Conversation

aabhas-sao
Copy link
Contributor

What changes are being made and why?

Previously command palette was not coming on pressing F1, I observed that an import needs to be added to enable that functionality. Added the required import.
closes #5687


How the changes have been QAed?

tested changes locally, please check out screenshot below.
Screenshot 2025-01-26 at 12 13 06 AM

@MilosPaunovic MilosPaunovic self-requested a review January 27, 2025 07:19
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch @aabhas-sao, thanks for this! 🚀

I've just added a custom keyboard shortcut on top, as often the F1 button has an function related to it, so this might be a bit more user-friendly.

@MilosPaunovic MilosPaunovic merged commit bc63068 into kestra-io:develop Feb 4, 2025
3 of 5 checks passed
MilosPaunovic added a commit that referenced this pull request Feb 5, 2025
Signed-off-by: Aabhas Sao <[email protected]>
Co-authored-by: Miloš Paunović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable the keyboard shortcut to change the editor font size from the UI code editor
2 participants