This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fixed Healthbar #38
Open
Fixed Healthbar #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketanhwr
reviewed
Jan 16, 2018
scripts/levels.js
Outdated
| @@ -1689,97 +1692,7 @@ function traceRay() | |||
| } | |||
| } | |||
|
|
|||
| function traceRay0() // for tracing the ray path | |||
There was a problem hiding this comment.
Why have you removed this function?
There was a problem hiding this comment.
Sorry that was accidental, I thought that TraceRay0() was a copy of TraceRay().
There was a problem hiding this comment.
Can you reject this pull request so I can submit a new one?
I re-added the deleted code
There was a problem hiding this comment.
Changes made to a branch used for a pull request will reflect on the pull request until the pull request is successfully merged.
Hn5624
commented
Jan 16, 2018
scripts/levels.js
Outdated
| @@ -1689,97 +1692,7 @@ function traceRay() | |||
| } | |||
| } | |||
|
|
|||
| function traceRay0() // for tracing the ray path | |||
There was a problem hiding this comment.
Can you reject this pull request so I can submit a new one?
I re-added the deleted code
|
The mirror position is still not fixed unfortunately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about that, I finally figured out how to completely work github, that and I kinda lost track of this project. Should work correctly now.
Also, I think it might be a good idea to implement a more realistic star background, I was thinking something like this. I believe it is a more efficient way to generate a background.
https://www.youtube.com/watch?v=17WoOqgXsRM&t=1s
I also have a copy in my github of that project github with keyboard controls if you want to check it out. Its under Programming Challanges/ #1 Starfield traveling