This repository has been archived by the owner on May 1, 2024. It is now read-only.
Restructured level definition #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, thanks for your additions. I'll test this out once and merge if everything works fine. Also, give me a reminder in a week or two incase I forget to merge it. |
|
Hi @ketanhwr I wonder if you could check the refactor out? |
|
@ketanhwr is anything going on with this? i wrote up a level class constructor that i would like to add to it thanks |
|
Hello @ketanhwr, I'm just giving you a reminder as per your request xD |
|
Hey, I'll try to check this out in a week. Let's get this done. |
|
It would be great 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the way of adding new levels into a JSON object definition.
I think a next step would be probably better the separation of levels into different files and then a live screen for level creation would be easy to implement