-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Designs a new "fsTeardown" API #6
Conversation
360ff32
to
82ac785
Compare
Hey, @nzakas. I'd like to re-design the public API of this library and wanted to ask your opinion on the proposed changes. You can find the updated README on this feature branch. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Nice work.
I wonder if Some alternatives to
|
I think prepare is fine, but if you want to be explicit, you could use writeToDisk. |
Agreed. I'll keep |
@nzakas, if you need help updating ESLint with these changes just let me know. I may need a quick intro to your custom setup to migrate it efficiently. |
We likely won’t update the tests, as they are working fine right now, but if you’d like to try doing it yourself, please feel free. |
This is a breaking change.
Motivation
Breaking changes
createTeardown
is renamed tofsTeardown
to be aligned with the package's name..getPath
is renamed to.resolve
to be aligned withpath.resolve
..addFile
was replaced with.create
that allows creating files and directories..reset()
method that restores the directory to its initial state (paths
from thefsTeardown
call).