Feature/sitecore82 #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Fixed the issue I was having too. |
|
Is there an timeline for when this pull request will be approved and available from nuget? I have a few projects that rely on this fix, while I can just compile and add it myself I'd rather have it available in nuget for future updates. |
|
Thanks - this fixed the issue we were having 👍. Also keen to get this approved, merged and updated on the version published on NuGet. |
|
Great work on this 8.2 update. We just built the Pull Request code and output our own nuget package that is working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for Sitecore 8.2 Update 2 breaking API changes.
I made fix portable. Reflection is used to access new API added in Sitecore 8.2 Update 2.
Another option is to start using #ifdef and with it we have to maintain more complicated configuration and generate 2 sets of binaries.
If you think that now it is good time to start maintaining different Sitecore versions I am happy to help.
That is how it is implemented for one of my projects - https://github.com/dharnitski/Sitecore.Algolia.
I can add something similar to Ship.
This change is