Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error messages #38

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

joshblum
Copy link
Member

Adds human readable error messages using $ security error $errorcode to aid in debugging.

@joshblum joshblum requested a review from akalin-keybase March 11, 2019 14:27
@joshblum
Copy link
Member Author

ci failure is unrelated to these changes, go lint no longer supports golang version 1.8 golang/go#28291 should we drop support as well or change ci to use an older version of lint?

@maxtaco
Copy link
Contributor

maxtaco commented Mar 11, 2019

Drop support for 1.8!

@joshblum joshblum force-pushed the joshblum/keychain-CORE-10327 branch from c88af0c to a9e5530 Compare March 11, 2019 16:02
Copy link
Contributor

@akalin-keybase akalin-keybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshblum joshblum merged commit da9bb48 into master Mar 11, 2019
@joshblum joshblum deleted the joshblum/keychain-CORE-10327 branch March 11, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants