Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Update README.md #61

merged 1 commit into from
Apr 18, 2019

Conversation

leonjia0112
Copy link
Contributor

Add dependency requirements to the README file.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@frozencemetery
Copy link
Contributor

The url subject of your commit message should capture what the change is, not just what files have changed. For a change this small, there shouldn't be a body.

@leonjia0112
Copy link
Contributor Author

Request change resolved. Ready for a review.
@frozencemetery @lukehinds @mbestavros

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the commit message as Update README.md with package dependencies. This way when we do releases, we can use git log and grab the brief details of the change for the release notes.

@leonjia0112
Copy link
Contributor Author

I would change the commit message as Update README.md with package dependencies. This way when we do releases, we can use git log and grab the brief details of the change for the release notes.

This one sounds better! Thanks!

@frozencemetery frozencemetery merged commit be7ec99 into keylime:master Apr 18, 2019
@leonjia0112 leonjia0112 deleted the patch-1 branch May 8, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants