Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Add support for ECC key pair generation #747

Merged
merged 3 commits into from
Feb 26, 2024
Merged

crypto: Add support for ECC key pair generation #747

merged 3 commits into from
Feb 26, 2024

Conversation

ansasaki
Copy link
Contributor

Also, implement some unit tests in tpm.rs

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.86792% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 61.35%. Comparing base (03c7164) to head (adddc35).

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 57.58% <5.76%> (-0.51%) ⬇️
upstream-unit-tests 51.01% <27.58%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keylime/src/crypto.rs 64.73% <42.10%> (+0.14%) ⬆️
keylime/src/tpm.rs 66.18% <5.88%> (-1.49%) ⬇️

ueno
ueno approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general; you might want to adjust .gitleaks.toml to suppress secret scanning.

keylime/src/crypto.rs Outdated Show resolved Hide resolved
keylime/src/crypto.rs Outdated Show resolved Hide resolved
keylime/src/crypto.rs Outdated Show resolved Hide resolved
keylime/src/crypto.rs Outdated Show resolved Hide resolved
keylime/src/tpm.rs Outdated Show resolved Hide resolved
@ansasaki
crypto: Add test for match_cert_to_template()
e92bf64 
Also make test_x509() parametrized and add test_x509_rsa()

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki
crypto: Implement ECC key generation support
2a84202 
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki
tpm: Add unit test for uncovered public functions
adddc35 
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki ansasaki merged commit 2f7b3ad into keylime:master Feb 26, 2024
9 of 10 checks passed
@ansasaki ansasaki deleted the ecc branch February 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

@lukehinds lukehinds Awaiting requested review from lukehinds

@lkatalin lkatalin Awaiting requested review from lkatalin

Assignees

@lukehinds lukehinds

@lkatalin lkatalin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ansasaki @ueno @lukehinds @lkatalin