Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Normalization needs to support multiple markers 🙀 #10320

Closed
srl295 opened this issue Jan 4, 2024 · 1 comment · Fixed by #10326
Closed

feat(core): Normalization needs to support multiple markers 🙀 #10320

srl295 opened this issue Jan 4, 2024 · 1 comment · Fixed by #10326
Assignees
@srl295
Labels
core/ Keyman Core epic-ldml feat m:normalization
Milestone
A17S30

Comments

@srl295
Copy link
Member

srl295 commented Jan 4, 2024

  • Split from #9468
  • need to support multiple markers-per-char
  • i.e. \m{a}\m{b}X
@srl295 srl295 added this to the A17S29 milestone Jan 4, 2024
@srl295 srl295 self-assigned this Jan 4, 2024
@keymanapp-test-bot keymanapp-test-bot bot added core/ Keyman Core feat labels Jan 4, 2024
@srl295 srl295 mentioned this issue Jan 4, 2024
Closed
@mcdurdin mcdurdin modified the milestones: A17S29, A17S30 Jan 6, 2024
srl295 added a commit that referenced this issue Jan 6, 2024
@srl295
chore(core): stacked markers tests 🙀
52fe907 
- first we break

#10320
srl295 added a commit that referenced this issue Jan 6, 2024
@srl295
feat(core): stacked markers tests 🙀
3f0c1fb 
- WIP fix

#10320
srl295 added a commit that referenced this issue Jan 6, 2024
@srl295
feat(core): stacked markers 🙀
b2b8979 
- renamed the single-segment functions to normalize_nfd_markers_segment() since they should only be run on a single segment
- commented out NFC for now, dead code
- add some additional checks/DebugLog around normalization

#10320
@srl295 srl295 mentioned this issue Jan 6, 2024
Merged
srl295 added a commit that referenced this issue Jan 6, 2024
@srl295
chore(core): split out some files 🙀
f38054f 
- markers/normalization really needs its own file
- split out ldml_markers.* from ldml_transforms.*
- split out ldml_utils.hpp for a common assert macro

#10320
@srl295 srl295 mentioned this issue Jan 6, 2024
Merged
srl295 added a commit that referenced this issue Jan 6, 2024
@srl295
feat(core): stacked markers 🙀
776a902 
- build fix for win

#10320
srl295 added a commit that referenced this issue Jan 11, 2024
@srl295
chore(core): split out some files 🙀
d4873d3 
- reapply 0d9f543 code review comments

#10320
@mcdurdin mcdurdin linked a pull request Jan 12, 2024 that will close this issue
feat(core): support stacked markers, prep for marker segments 🙀 #10326
Merged
@mcdurdin
Copy link
Member

Fixed by #10326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
core/ Keyman Core epic-ldml feat m:normalization
Projects
None yet
Milestone
A17S30
Development

Successfully merging a pull request may close this issue.

feat(core): support stacked markers, prep for marker segments 🙀 keymanapp/keyman
2 participants
@srl295 @mcdurdin