Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add other non-printing characters to OSK font #6167

Closed
mcdurdin opened this issue Jan 26, 2022 · 2 comments
Closed

chore: add other non-printing characters to OSK font #6167

mcdurdin opened this issue Jan 26, 2022 · 2 comments
Assignees
@mcdurdin
Labels
chore common/ m:osk On Screen Keyboard or Touch Keyboard, all platforms
Milestone
A18S8

Comments

@mcdurdin
Copy link
Member

Is there any way to mark special characters, such as: ZWSP, ZWNJ, ZWJ visually on the OSK?

See silnrsi/font-keymanweb-osk#3

Originally posted by @mcdurdin in keymanapp/keyboards#1710 (comment)
@mcdurdin mcdurdin transferred this issue from keymanapp/keyboards Jan 26, 2022
@mcdurdin mcdurdin added this to the 16.0 milestone Jan 26, 2022
@mcdurdin mcdurdin modified the milestones: 16.0, 17.0 Oct 14, 2022
@mcdurdin mcdurdin modified the milestones: 17.0, Future Dec 9, 2022
@mcdurdin mcdurdin mentioned this issue Sep 4, 2023
Merged
@darcywong00
Copy link
Contributor

darcywong00 commented Sep 7, 2023 •
edited
Loading

KMW OSK font updated in #9469 so remaining work is to use the labels (*ZWSP* etc)

keyman/web/src/engine/osk/src/specialCharacters.ts

Lines 36 to 45 in a47f723

// Added in Keyman 14.0.
'*LTREnter*': 0x05, // Default alias of '*Enter*'.
'*LTRBkSp*': 0x04, // Default alias of '*BkSp*'.
'*RTLEnter*': 0x71,
'*RTLBkSp*': 0x72,
'*ShiftLock*': 0x73,
'*ShiftedLock*': 0x74,
'*ZWNJ*': 0x75, // If this one is specified, auto-detection will kick in.
'*ZWNJiOS*': 0x75, // The iOS version will be used by default, but the
'*ZWNJAndroid*': 0x76, // Android platform has its own default glyph.

Reference for the symbols
https://github.com/silnrsi/font-symchar/blob/v3.000/documentation/encoding.md

darcywong00 added a commit that referenced this issue Sep 10, 2023
@darcywong00
chore(web): Add other non-printing characters from OSK font
3177fef 
Addresses #6167 for KeymanWeb by defining PUA points per https://github.com/silnrsi/font-symchar/blob/v3.000/documentation/encoding.md
darcywong00 added a commit that referenced this issue Sep 10, 2023
@darcywong00
chore(web): Add other non-printing characters from OSK font
4a3f748 
Addresses #6167 for KeymanWeb by defining PUA points per https://github.com/silnrsi/font-symchar/blob/v3.000/documentation/encoding.md
darcywong00 added a commit that referenced this issue Sep 11, 2023
@darcywong00
chore(web): Add other non-printing characters from OSK font
1817a2d 
Addresses #6167 for KeymanWeb by defining PUA points per https://github.com/silnrsi/font-symchar/blob/v3.000/documentation/encoding.md
@darcywong00 darcywong00 mentioned this issue Sep 11, 2023
Merged
@mcdurdin mcdurdin added the m:osk On Screen Keyboard or Touch Keyboard, all platforms label Sep 16, 2023
@mcdurdin mcdurdin modified the milestones: Future, A18S3 Apr 19, 2024
@mcdurdin mcdurdin self-assigned this Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S3, A18S5 May 26, 2024
@mcdurdin mcdurdin modified the milestones: A18S5, A18S7 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@mcdurdin
Copy link
Member Author

mcdurdin commented Aug 6, 2024

Calling this done, enough for now.

@mcdurdin mcdurdin closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore common/ m:osk On Screen Keyboard or Touch Keyboard, all platforms
Projects
None yet
Milestone
A18S8
Development

No branches or pull requests
2 participants
@mcdurdin @darcywong00