-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(developer): Rework Touch Layout Editor to support flick and multitap 🙊 #6884
Merged
mcdurdin
merged 23 commits into
master
from
feat/developer/touch-layout-editor-flick-and-multitap
Jul 25, 2022
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c88826c
chore(developer): refactor builder.js
mcdurdin f8f2715
chore(developer): refactor undo actions out of builder.js
mcdurdin 83bf20c
chore(developer): refactor 'constants' out of builder.js
mcdurdin 054423f
chore(developer): refactor subkeys out of builder.js
mcdurdin 5875cf5
chore(developer): update jquery-ui version to 1.13.1
mcdurdin a637b58
feat(developer): rework touch layout editor
mcdurdin feee081
feat(developer): tweaks ui for selected key cap
mcdurdin 268ba98
feat(developer): Support new touch layout definitions in Delphi
mcdurdin f9241f4
chore(developer): minor cleanup
mcdurdin d294684
chore(developer): remove multitap icon cleanly
mcdurdin b702b7d
fix(developer): fix issues with template and presentation
mcdurdin 60dabb5
feat(developer): add support for flick and multitap to compiler
mcdurdin 51a94a1
feat(developer): cleanup touch layout files on load and save
mcdurdin 11d8a3a
feat(developer): add hint properties to touch layout schema
mcdurdin 54a655e
feat(developer): add hint and displayHint to touch layout validation …
mcdurdin a362f27
feat(developer): add hint property to touch layout editor
mcdurdin 1738f12
feat(developer): add displayHint property to touch layout editor
mcdurdin 02d0358
chore(developer): simplify dialog workflow
mcdurdin 6032181
feat(developer): rework displayHint to defaultHint
mcdurdin c8971a4
chore: Apply suggestions from code review
mcdurdin ca47fce
Merge pull request #6917 from keymanapp/feat/developer/touch-layout-s…
mcdurdin dfb9776
Merge pull request #6925 from keymanapp/feat/developer/touch-layout-c…
mcdurdin b438a20
Merge pull request #6936 from keymanapp/feat/developer/5079-touch-lay…
mcdurdin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ class function TKeymanDeveloperPaths.NodePath: string; | |
KeymanRoot: string; | ||
begin | ||
if TKeymanPaths.RunningFromSource(KeymanRoot) | ||
then Result := KeymanRoot + 'developer\src\inst\dist\node.exe' | ||
then Result := KeymanRoot + 'developer\src\inst\node\dist\node.exe' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixup for node loading when running Developer from within a debugger in the source path. |
||
else Result := ExtractFilePath(ParamStr(0)) + 'node.js\node.exe'; | ||
end; | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do allow sub-paths, just not parent navigation -- this fixes loading of jquery-ui images.