Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android/engine): Remove help bubble tool tip #7473

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Oct 18, 2022

Fixes #6734
Rather than fixing the display of the help bubble, we'll remove it for 16.0 and re-implement it in a future release.

This does deprecate the two KMManager calls:

isHelpBubbleEnabled()
setHelpBubbleEnabled()

TODO:

User Testing

Setup - Install the PR build of Keyman for Android

  • TEST_BASIC - Verifies app still works
  1. Launch Keyman for Android and dismiss the "Get Started" menu
  2. Verify no help bubble tooltip is displayed on the globe key
  3. Short-press the globe key
  4. When 1 keyboard is installed, verify the keyboard picker menu is displayed
  5. Dismiss the menu

@darcywong00 darcywong00 requested a review from mcdurdin as a code owner October 18, 2022 04:31
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 18, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 18, 2022

User Test Results

Test specification and instructions

  • TEST_BASIC (PASSED): Tested this with the attached PR build (Keyman 16.0.83-alpha-test-7473) in my Android Mobile device (Ver 11) and verified that there is no bubble tip appears on the globe key after dismissing the 'Get Started' menu. I could able to see the the Keyboard picker menu opens, I short clicked the globe key.

Test Artifacts

@bharanidharanj
Copy link

  • TEST_BASIC (PASSED): Tested this with the attached PR build (Keyman 16.0.83-alpha-test-7473) in my Android Mobile device (Ver 11) and verified that there is no bubble tip appears on the globe key after dismissing the 'Get Started' menu. I could able to see the the Keyboard picker menu opens, I short clicked the globe key.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 18, 2022
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I suggest that we implement this in a future version as a native KMW widget.

@darcywong00 darcywong00 merged commit 5e402a2 into master Oct 20, 2022
@darcywong00 darcywong00 deleted the fix/android/remove-help-tip branch October 20, 2022 01:16
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 16.0.85-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(android): help tip misalignment
4 participants