Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
n-api: fix TypedAarray info for ArrayBuffer offset
The JsGetTypedArrayStorage API returns a buffer pointer that already incorporates the offset into the ArrayBuffer, so adding the offset was a mistake. This bug was caught by the N-API C++ wrapper tests at https://github.com/nodejs/node-addon-api/blob/master/test/typedarray.js PR-URL: nodejs#259 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Taylor Woll <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
- Loading branch information